Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to inject css and js files #7689

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Sep 26, 2022

This PR introduces the ability to configure scripts and style resources that will be injected into the SPA application.
This enables for example injection of small self containing scripts or style adjustments without rebuilding web or build a custom application.

needs owncloud/ocis#4664

@update-docs
Copy link

update-docs bot commented Sep 26, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need an async function here

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.3% 5.3% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit 7bd30e1 into experimental Sep 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the custom-scripts-and-styles branch September 26, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants