[full-ci] Keyboard navigation disable for inputs #7648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
reviewed
Sep 16, 2022
packages/web-app-files/src/components/FilesList/KeyboardActions.vue
Outdated
Show resolved
Hide resolved
|
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/28384/54/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingAcceptShares-acceptShares_feature-L228.png |
AlexAndBear
approved these changes
Sep 16, 2022
| @@ -86,6 +86,8 @@ export default defineComponent({ | |||
| }), | |||
|
|
|||
| areCustomKeyBindingsEnabled() { | |||
| const activeElementTag = document.activeElement.tagName | |||
| if (['textarea', 'input', 'select'].includes(activeElementTag.toLowerCase())) return true | |||
There was a problem hiding this comment.
Personally not a fan of the inline return without {}
There was a problem hiding this comment.
Same. Code style in web and related repos is to not inline return statements.
There was a problem hiding this comment.
Tried to find a eslint rule set plugin, but nothing found unfortantly
lookacat
changed the title
lookacat
force-pushed
the
keyboard-navigation-disable-for-inputs
branch
from
ba505a6 to
3a180b5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
delete-merged-branch
bot
deleted the
keyboard-navigation-disable-for-inputs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable keyboard navigation on textarea and input
Types of changes
Checklist: