-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Optimize share loading part II #7638
Conversation
Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/28342/38/1 |
86211a6
to
8c29a6f
Compare
029fa59
to
3d6a77d
Compare
3d6a77d
to
093dfb8
Compare
// FIXME: We need the storageId of each parent resource here | ||
const spaceRef = indirect ? null : storageId |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ugly... We can't take the storageId
of the current resource for each of its parents. This currently results in incorrect indirect shares being displayed when both of the following applies:
a) You are in in nested folder (at least 2 levels deep)
b) You (re-)load the page within the folder. Navigating from the outside into the folder should be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 💪 Only some nitpicks about mutation naming, see comments.
SonarCloud Quality Gate failed. |
Description
Continuation of #7580
loadCurrentFileOutgoingShares
andloadIncomingShares
mutations. Instead, incoming and outgoing shares are now being loaded vialoadSharesTree()
. This avoidsgetShare()
requests from being executed multiple times.Types of changes