Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare Save Dialog, simplify #7612

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Compare Save Dialog, simplify #7612

merged 1 commit into from
Sep 8, 2022

Conversation

AlexAndBear
Copy link
Contributor

Description

Follow up of #7609

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Sep 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kulmann
kulmann requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the padding at the bottom of the wrapper is too big. Should be the same as above the label at the top. See screenshot.

Screenshot 2022-09-08 at 22 14 39

@AlexAndBear
Copy link
Contributor Author

@kulmann this is the same margin bottom as in the share side bar. Spoken about this with @tbsbdr, there will be a fine design, but good for now.

@AlexAndBear AlexAndBear requested a review from kulmann September 8, 2022 20:18
@kulmann kulmann merged commit 1fedd27 into master Sep 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7585-2 branch September 8, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @kulmann