Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only]Use cached web in drone pipelines #7578

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Sep 2, 2022

Description

This PR has implemented using the cached web in the web pipeline and remove unnecessary step from pipelines

Related issue

cache build-web-integration-app step in web

@ownclouders
Copy link
Contributor

ownclouders commented Sep 2, 2022

@amrita-shrestha amrita-shrestha force-pushed the implementCacheInWebIntegeration branch from 54205ba to 6458726 Compare September 2, 2022 10:00
@saw-jan saw-jan force-pushed the implementCacheInWebIntegeration branch from 914ec57 to 51c8b2a Compare September 2, 2022 10:53
@amrita-shrestha amrita-shrestha force-pushed the implementCacheInWebIntegeration branch from 51c8b2a to 46310b4 Compare September 2, 2022 11:27
@amrita-shrestha amrita-shrestha changed the title [full-ci][tests-only]Use Cached ocis in integration pipelines [full-ci][tests-only]Use cached web in drone pipelines Sep 5, 2022
@amrita-shrestha amrita-shrestha marked this pull request as ready for review September 5, 2022 03:10
@grgprarup
Copy link
Contributor

grgprarup commented Sep 5, 2022

@amrita-shrestha Also, don't forget to check and refactor in other owncloud repos. If needed make a checklist in the issue owncloud/QA#762.

@amrita-shrestha amrita-shrestha force-pushed the implementCacheInWebIntegeration branch from 46310b4 to 1a7ba8d Compare September 5, 2022 08:52
@saw-jan
Copy link
Member

saw-jan commented Sep 5, 2022

this line can also be removed. I think it has no use

web/.drone.star

Line 1370 in 46310b4

steps += restoreBuildArtifactCache(ctx, "yarn", ".yarn")

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis merged commit 437951c into master Sep 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the implementCacheInWebIntegeration branch September 5, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants