Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] Fix re-sharing flaky #7571

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

ScharfViktor
Copy link
Contributor

#7566
fix flaky: So far, I've disabled this check for oc10 to stabilize CI

As soon as we find a better solution, we'll enable it

@update-docs
Copy link

update-docs bot commented Sep 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor requested a review from kulmann September 1, 2022 14:09
@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Sep 1, 2022

although flacks are not only in oс10 https://drone.owncloud.com/owncloud/web/27992/12/13

so my first solution was bad

@ScharfViktor ScharfViktor changed the title [test-only] Disable transition checking for oc10 [test-only] Fix re-sharing flaky Sep 1, 2022
@ScharfViktor
Copy link
Contributor Author

how user do share in test:

  • user clicks "show context menu" on the resource
  • press "Details" btn
  • chooses "Shares" in sidebar (here check transition to shares panel)
  • do share

It works well for sharing from personal/project space (let it go on working - let's not interfere). For shares jail it works flaky

I added more easy workflow for sharing from shares jail:

  • user clicks "show context menu"
  • press "Share" btn
  • do share

@ScharfViktor
Copy link
Contributor Author

PR is ready to review. CI is without flaky

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants