Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust spacing of the files list options menu #7570

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Adjust spacing of the files list options menu #7570

merged 1 commit into from
Sep 2, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We've adjusted the spacing of the files list options menu to visually match with the other menus.

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 1, 2022
@JammingBen JammingBen requested a review from kulmann September 1, 2022 11:42
@ownclouders
Copy link
Contributor

ownclouders commented Sep 1, 2022 •
edited
Loading

Results for oCISSharingPerm1 https://drone.owncloud.com/owncloud/web/27996/64/1
💥 The oCISSharingPerm1 tests pipeline failed. The build has been cancelled.

@kulmann
Copy link
Member

kulmann commented Sep 1, 2022 •
edited
Loading

unit tests need to be adjusted sorry, wanted to comment on another PR.

The e2e test in oc10 is flaky. restarting CI...

@JammingBen
Copy link
Contributor Author

Hmm no, oC10 e2e tests again...

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit ec6649f into master Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the files-list-options-menu-spacing branch September 2, 2022 05:41
@micbar micbar mentioned this pull request Sep 12, 2022
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

padding on file list setting pop up seems off
3 participants
@JammingBen @ownclouders @kulmann