Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover effect for left sidebar #7567

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Add hover effect for left sidebar #7567

merged 2 commits into from
Sep 1, 2022

Conversation

JammingBen
Copy link
Contributor

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit fb0d810 into master Sep 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the left-sidebar-hover branch September 1, 2022 10:14
@diocas
Copy link
Contributor

diocas commented Sep 1, 2022

This PR is causing a strange visual effect. When I click in the menu, the background of the entry changes immediately. But then the effect that was there before still happens, so you see 2 blue boxes merging.

In the picture you can see what happens when switching from (the previously selected) "Personal" to "Deleted files"
Screenshot 2022-09-01 at 17 29 56

@kulmann
Copy link
Member

kulmann commented Sep 1, 2022

This PR is causing a strange visual effect. When I click in the menu, the background of the entry changes immediately. But then the effect that was there before still happens, so you see 2 blue boxes merging.

In the picture you can see what happens when switching from (the previously selected) "Personal" to "Deleted files" Screenshot 2022-09-01 at 17 29 56

True... thank you! Fixed in #7575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent hover effect (left sidebar)
4 participants