Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] add a full CI and early fail support for the e2e test pipelines #7558

Merged
merged 3 commits into from
Sep 1, 2022
Merged

[full-ci][tests-only] add a full CI and early fail support for the e2e test pipelines #7558

merged 3 commits into from
Sep 1, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Aug 31, 2022 •
edited
Loading

Description

  • Add config dict for e2e test pipes
  • Early fail on e2e test pipes
  • If full-ci then, no early fail on e2e test pipes

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589
Copy link
Contributor Author

with skip set as True: https://drone.owncloud.com/owncloud/web/27925

@kiranparajuli589 kiranparajuli589 changed the title [ci][tests-only] add full-ci and early fail support for the e2e pipelines [full-ci][ci][tests-only] add a full CI and early fail support for the e2e test pipelines Aug 31, 2022
@kiranparajuli589
Copy link
Contributor Author

with full-ci in the PR title and an intentional failure in the e2e suite: https://drone.owncloud.com/owncloud/web/27927

@kiranparajuli589 kiranparajuli589 changed the title [full-ci][ci][tests-only] add a full CI and early fail support for the e2e test pipelines [ci][tests-only] add a full CI and early fail support for the e2e test pipelines Aug 31, 2022
@kiranparajuli589
Copy link
Contributor Author

with no full-ci and an intentional error on the e2e pipes: https://drone.owncloud.com/owncloud/web/27928

@kiranparajuli589 kiranparajuli589 self-assigned this Aug 31, 2022
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review August 31, 2022 10:19
grgprarup
grgprarup reviewed Aug 31, 2022
View reviewed changes
ScharfViktor
ScharfViktor reviewed Aug 31, 2022
View reviewed changes
@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Aug 31, 2022 •
edited
Loading

@saw-jan will be looking on this from now, comment on fail needs some more investigation

ScharfViktor
ScharfViktor approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kiranparajuli589 and others added 2 commits September 1, 2022 10:38
@kiranparajuli589 @saw-jan
The acceptance tests pipelines now only depend on the unit tests pipe…
e75c95d 
…lines

Signed-off-by: Kiran Parajuli <[email protected]>

[not-fore-merge] intenionally fail a e2e test to demonstrate the full-ci behaviour

Signed-off-by: Kiran Parajuli <[email protected]>

remove intentionally added failure

Signed-off-by: Kiran Parajuli <[email protected]>

Adress reviews

Signed-off-by: Kiran Parajuli <[email protected]>
@saw-jan
generate pipelines using matrices
b5405e0
@owncloud owncloud deleted a comment from ownclouders Sep 1, 2022
@saw-jan saw-jan force-pushed the full-ci-on-e2e branch 2 times, most recently from 9f3cb8e to a693e4c Compare September 1, 2022 06:20
@ownclouders
Copy link
Contributor

ownclouders commented Sep 1, 2022 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/27961/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27961/tracing/re-sharing-alice-2022-9-1-07-25-20.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27961/tracing/re-sharing-brian-2022-9-1-07-25-28.zip

@saw-jan
Copy link
Member

saw-jan commented Sep 1, 2022 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/27957/12/1 boom The e2e-ocis tests pipeline failed. The build has been cancelled.

✔️ acceptance is not dependent to e2e: https://drone.owncloud.com/owncloud/web/27957
✔️ Early fail comment working: https://drone.owncloud.com/owncloud/web/27957
✔️ Can skip individual e2e pipeline: https://drone.owncloud.com/owncloud/web/27958
✔️ with "full-ci" build won't get stopped: https://drone.owncloud.com/owncloud/web/27960

The PR is now ready!

CC @ScharfViktor @individual-it

@saw-jan saw-jan force-pushed the full-ci-on-e2e branch 2 times, most recently from 7bf1de6 to 0e07ab4 Compare September 1, 2022 06:50
@saw-jan saw-jan changed the title [ci][tests-only] add a full CI and early fail support for the e2e test pipelines [full-ci][tests-only] add a full CI and early fail support for the e2e test pipelines Sep 1, 2022
@saw-jan
Copy link
Member

saw-jan commented Sep 1, 2022 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/27961/11/1

To see the trace, please open the link in the console ...

known issue with e2e tests: #7566

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 8ad08ff into master Sep 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the full-ci-on-e2e branch September 1, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] add ability to run the full webUI CI without stopping early
6 participants
@kiranparajuli589 @ownclouders @saw-jan @individual-it @grgprarup @ScharfViktor