Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] add step sharing with group #7544

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[tests-only] add step sharing with group #7544

merged 1 commit into from
Aug 31, 2022

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Aug 29, 2022 •
edited by phil-davis
Loading

related #7041

  • added step share/reshare with group to reshare.ocis.feature
  • enabled re sharing test for oc10

@ownclouders
Copy link
Contributor

ownclouders commented Aug 29, 2022 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/27895/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/participant-management-alice-2022-8-29-03-54-23.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/participant-management-anonymous-2022-8-29-03-54-44.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/participant-management-brian-2022-8-29-03-54-28.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/participant-management-carol-2022-8-29-03-54-33.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/public-link-for-space-alice-2022-8-29-03-58-28.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/public-link-for-space-brian-2022-8-29-03-58-54.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/public-link-for-space-marie-2022-8-29-03-58-58.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27895/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-8-29-03-56-23.zip

SagarGi
SagarGi reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ScharfViktor
add step sharing with group
fdf46b0 
lint fix

fix

run reshare test in oc10
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@owncloud owncloud deleted a comment from update-docs bot Aug 31, 2022
@phil-davis phil-davis changed the title add step sharing with group [tests-only] add step sharing with group Aug 31, 2022
@phil-davis phil-davis merged commit e386e4c into master Aug 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the sharingWithGroupTest branch August 31, 2022 04:13
@grgprarup grgprarup mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScharfViktor @ownclouders @phil-davis @SagarGi