Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Bump commit id for tests #7520

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Aug 25, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@ownclouders
Copy link
Contributor

ownclouders commented Aug 25, 2022

Results for oC10Upload https://drone.owncloud.com/owncloud/web/27843/39/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L94.png

webUIUpload-upload_feature-L94.png

@SwikritiT
Copy link
Contributor Author

@kulmann @ScharfViktor In this PR a lot of tests are failing because we cannot create folder with special characters in ocis I could reproduce the problem locally as well
Screenshot from 2022-08-25 14-43-06

Is this the expected behaviour or some regression?

@ScharfViktor
Copy link
Contributor

I couldn't reproduce it on release branch
ownCloud Web UI 5.7.0-rc.10
ocis local actual master

image

@SwikritiT
Copy link
Contributor Author

I'm using the current master for web and running ocis through docker.

@SwikritiT
Copy link
Contributor Author

SwikritiT commented Aug 25, 2022

@ScharfViktor for me if the name consists of character & the folder doesn't get created

folderwithand

Can you try reproducing in the current master of both ocis and web?

@ScharfViktor
Copy link
Contributor

Yeah, I reproduce it.
fresh master, ocis with docker

image

web 5.7.0-rc.10 embedded in osis gives me no error. This means that something broke after the web release

@SwikritiT
Copy link
Contributor Author

Yeah, I reproduce it. fresh master, ocis with docker

image

web 5.7.0-rc.10 embedded in osis gives me no error. This means that something broke after the web release

I've opened up a issue here owncloud/ocis#4474. I don't know if this is a backend issue or frontend. What do we do now for this? Bump commit id PR will be blocked. I'm going to put all the failing tests in expected to fail for now and get this PR unblocked.

@SwikritiT SwikritiT force-pushed the bump-commit-id-20220825 branch from 1c67caf to 6643057 Compare August 26, 2022 04:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT marked this pull request as ready for review August 26, 2022 05:49
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis
Copy link
Contributor

When the bug related to "&" is fixed, the developer will be able to confirm the fix is good, because this list of tests should start passing and can be removed from expected-failures at that time.

@phil-davis phil-davis merged commit 73c7f40 into master Aug 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-20220825 branch August 26, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants