-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Fix right sidebar content on small screens #7508
Conversation
@kulmann How "bad" is it that the batch actions always show a tooltip if the right sidebar is open? If that's an issue, I probably need to solve this in JS and use a resize observer... which I really don't want to 😅 |
Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/27775/57/1 |
499220c
to
4b3c8db
Compare
4b3c8db
to
d5d629e
Compare
packages/web-app-files/src/components/AppBar/SelectedResources/BatchActions.vue
Outdated
Show resolved
Hide resolved
I have one more: with an active file clipboard we'd need to apply the same logic to buttons without selection. You can reach this state by e.g. copying or cutting files and then navigating into a different folder. See screenshot below, on small screens the right sidebar gets cropped again. For the |
Oof. Yeah that's right, haven't thought of that. The same applies to the "New" and the "Upload" button as well, but only in the "active clipboard" + sidebar open state, correct? |
Thought about it with @tbsbdr - could we hide the labels of |
Sure. One question remains though: How do we deal with tooltips? The batch actions now always have a tooltip - the same would apply here. The alternative would be to mess around with a resize observer and toggle the tooltips conditionally depending on the screen size. |
would be good to hide the tooltips if the labels are visible |
SonarCloud Quality Gate failed. |
Description
We've fixed the right sidebar content on small screens because some screen sizes caused the content to flow out of the screen. Things that have been done to achieve this:
Related Issue
Types of changes