Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Fix right sidebar content on small screens #7508

Merged
merged 6 commits into from
Aug 26, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We've fixed the right sidebar content on small screens because some screen sizes caused the content to flow out of the screen. Things that have been done to achieve this:

  • Selection info has been removed.
  • Labels of the batch actions will hide on screens <1280px if the sidebar is open.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 23, 2022
@JammingBen
Copy link
Contributor Author

@kulmann How "bad" is it that the batch actions always show a tooltip if the right sidebar is open? If that's an issue, I probably need to solve this in JS and use a resize observer... which I really don't want to 😅

@ownclouders
Copy link
Contributor

ownclouders commented Aug 23, 2022

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/27775/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesList-fileList_feature-L50.png

webUIFilesList-fileList_feature-L50.png

@JammingBen JammingBen changed the title Fix right sidebar content on small screens [full-ci] Fix right sidebar content on small screens Aug 24, 2022
@JammingBen JammingBen force-pushed the fix-sidebar-view-on-small-screens branch from 499220c to 4b3c8db Compare August 24, 2022 07:06
@JammingBen JammingBen force-pushed the fix-sidebar-view-on-small-screens branch from 4b3c8db to d5d629e Compare August 24, 2022 08:13
@JammingBen JammingBen marked this pull request as ready for review August 24, 2022 09:34
@JammingBen JammingBen requested a review from kulmann August 24, 2022 09:34
@JammingBen JammingBen requested a review from kulmann August 24, 2022 12:21
@kulmann
Copy link
Contributor

kulmann commented Aug 24, 2022

I have one more: with an active file clipboard we'd need to apply the same logic to buttons without selection. You can reach this state by e.g. copying or cutting files and then navigating into a different folder. See screenshot below, on small screens the right sidebar gets cropped again. For the Paste here button I suspect that we'll need a divider between the Paste and Cancel icons in the button group...

Screenshot 2022-08-24 at 14 47 01

@JammingBen
Copy link
Contributor Author

Oof. Yeah that's right, haven't thought of that. The same applies to the "New" and the "Upload" button as well, but only in the "active clipboard" + sidebar open state, correct?

@kulmann
Copy link
Contributor

kulmann commented Aug 24, 2022

Oof. Yeah that's right, haven't thought of that. The same applies to the "New" and the "Upload" button as well, but only in the "active clipboard" + sidebar open state, correct?

Thought about it with @tbsbdr - could we hide the labels of New and Upload, but keep the label of Paste here? The first two buttons are easier to understand than the paste button.

@JammingBen
Copy link
Contributor Author

Sure. One question remains though: How do we deal with tooltips? The batch actions now always have a tooltip - the same would apply here. The alternative would be to mess around with a resize observer and toggle the tooltips conditionally depending on the screen size.

@tbsbdr
Copy link

tbsbdr commented Aug 24, 2022

would be good to hide the tooltips if the labels are visible

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.1% 54.1% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit a08fea1 into master Aug 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-sidebar-view-on-small-screens branch August 26, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar content floats out of the screen
4 participants