Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary PROPFIND request during upload #7488

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Prevent unnecessary PROPFIND request during upload #7488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-prevent-unnecessary-propfind-during-upload
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Prevent unnecessary PROPFIND request during upload

We've removed the unnecessary PROPFIND request at the start of each upload, increasing upload performance especially in larger folders.

https://github.com/owncloud/web/issues/7486
https://github.com/owncloud/web/pull/7488
14 changes: 1 addition & 13 deletions packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,7 @@ export default defineComponent({
}
}

let pathFileWasUploadedTo = file.meta.currentFolder
if (file.meta.relativeFolder) {
pathFileWasUploadedTo += file.meta.relativeFolder
}

const fileIsInCurrentPath = pathFileWasUploadedTo === this.currentPath

const fileIsInCurrentPath = file.meta.currentFolder === this.currentPath
if (fileIsInCurrentPath) {
bus.publish('app.files.list.load')
}
Expand Down Expand Up @@ -788,12 +782,6 @@ export default defineComponent({
this.$uppyService.publish('uploadStarted')
await this.createDirectoryTree(files)
this.$uppyService.publish('addedForUpload', files)

const reloadRequired = !!files.find((f) => f.meta.currentFolder === this.currentPath)
if (reloadRequired) {
bus.publish('app.files.list.load')
}

this.$uppyService.uploadFiles(files)
},

Expand Down