Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only] e2e test for spaces publiclink story #7433

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds e2e test for public link spaces story.

Related Issue

#7407

How Has This Been Tested?

  • Locally
  • On CI

@update-docs
Copy link

update-docs bot commented Aug 11, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sushmita56 sushmita56 self-assigned this Aug 11, 2022
@sushmita56 sushmita56 assigned sushmita56 and unassigned sushmita56 Aug 11, 2022
@sushmita56 sushmita56 force-pushed the e2etest-for-spaces-publiclink branch 2 times, most recently from f63fa99 to 0a8ad22 Compare August 17, 2022 08:15
@sushmita56 sushmita56 marked this pull request as ready for review August 17, 2022 08:15
@sushmita56 sushmita56 changed the title [full-ci] e2e test for spaces publiclink story [full-ci][tests-only] e2e test for spaces publiclink story Aug 17, 2022
@sushmita56 sushmita56 force-pushed the e2etest-for-spaces-publiclink branch from 0a8ad22 to 4f3d5b7 Compare August 17, 2022 08:29
@sushmita56 sushmita56 force-pushed the e2etest-for-spaces-publiclink branch 2 times, most recently from 0985946 to 42f3559 Compare August 18, 2022 08:41
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing. rest lgtm 👍

@sushmita56 sushmita56 force-pushed the e2etest-for-spaces-publiclink branch from 42f3559 to 02a6033 Compare August 18, 2022 11:24
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works smoothly on my machine and code lgtm 👍

@kulmann kulmann requested a review from fschade August 19, 2022 07:09
@kulmann
Copy link
Contributor

kulmann commented Aug 19, 2022

Please wait for a review from @fschade before merging

Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the pr, please have a look at my comments.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT requested a review from fschade August 22, 2022 04:12
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sushmita56 sushmita56 merged commit aad5e32 into master Aug 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the e2etest-for-spaces-publiclink branch August 22, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants