-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci][tests-only] e2e test for spaces publiclink story #7433
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
f63fa99
to
0a8ad22
Compare
0a8ad22
to
4f3d5b7
Compare
tests/e2e/cucumber/features/integrations/spaces/publicLink.ocis.feature
Outdated
Show resolved
Hide resolved
tests/e2e/cucumber/features/integrations/spaces/publicLink.ocis.feature
Outdated
Show resolved
Hide resolved
tests/e2e/cucumber/features/integrations/spaces/publicLink.ocis.feature
Outdated
Show resolved
Hide resolved
tests/e2e/cucumber/features/integrations/spaces/publicLink.ocis.feature
Outdated
Show resolved
Hide resolved
0985946
to
42f3559
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small thing. rest lgtm 👍
42f3559
to
02a6033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works smoothly on my machine and code lgtm 👍
Please wait for a review from @fschade before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the pr, please have a look at my comments.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
This PR adds e2e test for public link spaces story.
Related Issue
#7407
How Has This Been Tested?