update space quota on upload, delete and restore #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/27400/12/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27400/tracing/participant-management-alice-2022-8-8-11-00-45.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27400/tracing/participant-management-anonymous-2022-8-8-11-01-01.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27400/tracing/participant-management-brian-2022-8-8-11-00-50.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27400/tracing/participant-management-carol-2022-8-8-11-00-55.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27400/tracing/public-link-alice-2022-8-8-10-58-33.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27400/tracing/public-link-anonymous-2022-8-8-10-58-46.zip |
added 2 commits
August 8, 2022 15:36
AlexAndBear
changed the title
AlexAndBear
commented
Aug 8, 2022
AlexAndBear
force-pushed
the
issues/6930
branch
from
6f8d576 to
81c32c9
Compare
AlexAndBear
commented
Aug 9, 2022
| @@ -45,7 +45,7 @@ export default { | |||
| return filesize(this.spaceQuota.used) | |||
| }, | |||
| quotaUsagePercent() { | |||
| return ((this.spaceQuota.used / this.spaceQuota.total) * 100).toFixed(1) | |||
| return parseFloat(((this.spaceQuota.used / this.spaceQuota.total) * 100).toFixed(2)) | |||
There was a problem hiding this comment.
Aligned to oc10 user quota view
AlexAndBear
commented
Aug 9, 2022
Comment on lines
-216
to
-218
| ...(user.quota && | ||
| user.quota.definition !== 'default' && | ||
| user.quota.definition !== 'none' && { quota: user.quota }) |
There was a problem hiding this comment.
I don't get this conditions, we load the user quota on other places without those conditions
AlexAndBear
commented
Aug 9, 2022
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
commented
Aug 9, 2022
|
SonarCloud Quality Gate failed. |
kulmann
reviewed
Aug 9, 2022
Comment on lines
-216
to
-218
| ...(user.quota && | ||
| user.quota.definition !== 'default' && | ||
| user.quota.definition !== 'none' && { quota: user.quota }) |
|
@kulmann If you can give me some tips, I can for sure remove some code duplication |
kulmann
requested changes
Aug 9, 2022
Nevermind. Just saw that the code duplication is in mixins. As we want to get rid of those it's not worth it I think. |
dschmidt
pushed a commit
that referenced
this pull request
Aug 10, 2022
kulmann
pushed a commit
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: While uploading files with uppy we check the quota of the respective space, this is why we should keep spaces in sync
Tackling the following issues:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: