-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Missing finedesign in Shares Panel #2 #7402
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10SharingPermission https://drone.owncloud.com/owncloud/web/27382/35/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L47.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L48.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L50.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L51.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L53.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L54.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L55.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L56.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L57.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L58.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L100.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L101.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L102.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L103.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L156.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L157.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L158.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L161.pngwebUISharingPermissionsUsers-sharePermissionsUsers_feature-L99.png |
8459ae7
to
d427bb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
While doing investigations e2e tests seems to be broken by ods bump FIXED BY: Still a weird thing... |
7ff4736
to
588efbb
Compare
588efbb
to
1fdbb26
Compare
Kudos, SonarCloud Quality Gate passed! |
selector: '.files-collaborators-collaborator-additional-info' | ||
selector: | ||
'//div[contains(@class, "share-access-details-drop")]//dt[contains(text(),"Additional info")]/following-sibling::dd[1]', | ||
locateStrategy: 'xpath' | ||
}, | ||
collaboratorShareType: { | ||
selector: '.files-collaborators-collaborator-share-type' | ||
selector: | ||
'//div[contains(@class, "share-access-details-drop")]//dt[contains(text(),"Type")]/following-sibling::dd[1]', | ||
locateStrategy: 'xpath' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 💪 🎨
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: