Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect space quota permission #7401

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Respect space quota permission #7401

merged 4 commits into from
Aug 4, 2022

Conversation

JammingBen
Copy link
Contributor

Description

By taking the space quota permission into account, we've fixed a bug where a regular space member could see the "Edit space quota" action.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 3, 2022
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/27323/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/27323/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-8-3-01-41-13.zip

@JammingBen JammingBen marked this pull request as ready for review August 3, 2022 14:42
@JammingBen JammingBen requested a review from kulmann August 4, 2022 06:27
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JammingBen JammingBen merged commit 20666b7 into master Aug 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the space-quota-permission branch August 4, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regular member should not be able to change Space quota
4 participants