Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected item bottom glue #7393

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Conversation

JammingBen
Copy link
Contributor

Description

We've fixed a bug where the selected item would be glued to the bottom when scrolling up via keyboard navigation. Also, the scrollTo param has been fixed and is now working again.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Aug 3, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Aug 3, 2022

Results for oCISSharingAutocompletion https://drone.owncloud.com/owncloud/web/27302/63/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L73.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L73.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L74.png

webUISharingAutocompletion-shareAutocompletionSpecialChars_feature-L74.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the fix-selected-item-bottom-glue branch from 66093c3 to e08688c Compare August 3, 2022 08:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review August 3, 2022 09:13
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm 💪

@kulmann kulmann merged commit 0e848f3 into master Aug 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-selected-item-bottom-glue branch August 3, 2022 09:28
@micbar micbar mentioned this pull request Aug 11, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected item glues on bottom & scrolls for ⬆️ key up
3 participants