Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loading state in projects view #7366

Merged
merged 1 commit into from
Jul 28, 2022
Merged

fix: loading state in projects view #7366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/unreleased/bugfix-loading-state-in-views
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ Bugfix: Loading state in views
We fixed a small glitch in views of the files app, where the view would show a state like "Resource not found" in the brief moment before the resource loading started. Now the views correctly start in a loading state.

https://github.com/owncloud/web/pull/7325
https://github.com/owncloud/web/pull/7366
4 changes: 4 additions & 0 deletions packages/web-app-files/src/views/spaces/Projects.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,15 @@ export default defineComponent({
loadedSpaces = loadedSpaces.map(buildSpace)
ref.LOAD_FILES({ currentFolder: null, files: loadedSpaces })
})
const areResourcesLoading = computed(() => {
return loadResourcesTask.isRunning || !loadResourcesTask.last
})

return {
spaces,
graphClient,
loadResourcesTask,
areResourcesLoading,
accessToken
}
},
Expand Down