[full-ci] fix: render loading state before loading starts #7325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
fix-loading-state-in-views
branch
from
c93f488 to
4d0aa06
Compare
|
Results for oC10Files5 https://drone.owncloud.com/owncloud/web/27070/21/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFiles-breadcrumb_feature-L50.png |
kulmann
changed the title
kulmann
changed the title
kulmann
force-pushed
the
fix-loading-state-in-views
branch
from
89f74f4 to
31ffb91
Compare
If the item is missing there's a warning in the browser console about item not matching the required format.
kulmann
force-pushed
the
fix-loading-state-in-views
branch
from
31ffb91 to
add7d7c
Compare
kulmann
force-pushed
the
fix-loading-state-in-views
branch
from
add7d7c to
adea522
Compare
dschmidt
approved these changes
Jul 27, 2022
lookacat
reviewed
Jul 27, 2022
| @@ -21,7 +21,7 @@ const propsData = { | |||
| active: false, | |||
| target: exampleNavItem.route.path, | |||
| icon: exampleNavItem.icon, | |||
| index: 5, | |||
| index: '5', | |||
There was a problem hiding this comment.
It's not. It just printed a warning to the console when running unit tests, so I fixed it. ;-)
|
Kudos, SonarCloud Quality Gate passed! |
9 tasks
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that the
Personalview showed theResource not foundcomponent for a brief moment before the resource loader task was started. This is due to the task API not announcing itself asisRunning=truewhen there is no task instance, yet. Fixed in all views by adding a check for the absence of a loader task instance (in addition to theisRunningcheck).Types of changes
Checklist: