fix: resize observer disconnect in sidebar highlighter #7324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
force-pushed
the
fix-resize-observer-disconnect
branch
from
64f2a42 to
ecb85e2
Compare
kulmann
changed the title
|
SonarCloud Quality Gate failed. |
kulmann
changed the title
JammingBen
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ResizeObserver in the sidebar nav highlighter was not set correctly, hence the console error messages when switching to a view without sidebar (see screenshot). Also inverted the early returns into conditional setters, because we always want to reach the code block where we add the beforeDestroy event listener.
Motivation and Context
Keep the browser console clean, correctly terminate resize observer.
Types of changes
Checklist: