Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scrolling in users and groups list #7321

Merged
merged 5 commits into from
Jul 26, 2022
Merged

Allow scrolling in users and groups list #7321

merged 5 commits into from
Jul 26, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 25, 2022 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear marked this pull request as ready for review July 25, 2022 07:38
kulmann
kulmann requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the area above the table and the table header visible at all times. Only the table content is supposed to scroll (same as in files app).

@AlexAndBear AlexAndBear requested a review from kulmann July 25, 2022 08:35
kulmann
kulmann requested changes Jul 25, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chrome the table header scrolls up a little bit until it stays sticky and only the content of the table continues to scroll. Two screenshots attached, please check the distance between "New user" button and table header respectively. Could you fix that so that the table header doesn't move at all?

Screenshot 2022-07-25 at 21 15 46

Screenshot 2022-07-25 at 21 15 56

@AlexAndBear AlexAndBear requested a review from kulmann July 26, 2022 07:52
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

46.7% 46.7% Coverage
34.4% 34.4% Duplication

@kulmann kulmann merged commit 15ecf32 into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7266 branch July 26, 2022 08:37
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No InfiniteScroll/Pagination on user-management pages users/groups
2 participants
@AlexAndBear @kulmann