Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resharing followup #7319

Merged
merged 5 commits into from
Jul 25, 2022
Merged

Resharing followup #7319

merged 5 commits into from
Jul 25, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jul 22, 2022 •
edited
Loading

Description

  • Fixed sidebar (& shares) not loading in sharing jail root folders (context menu via breadcrumb)
  • Fixed sharesTree console errors in share jail

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jul 22, 2022
@JammingBen JammingBen force-pushed the share-jail-followup branch from ec018a2 to e619b81 Compare July 25, 2022 08:24
@owncloud owncloud deleted a comment from update-docs bot Jul 25, 2022
@JammingBen JammingBen marked this pull request as ready for review July 25, 2022 08:48
@JammingBen JammingBen requested review from kulmann, fschade and AlexAndBear and removed request for kulmann and fschade July 25, 2022 08:48
@JammingBen JammingBen changed the title Share jail followup Resharing followup Jul 25, 2022
kulmann
kulmann suggested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all uses of the hasShareJail capability in the folder loader spaces/loaderShare.ts. It is only enabled at all if the share jail is announced, see line 24 of the file.

@JammingBen JammingBen requested a review from kulmann July 25, 2022 08:59
@kulmann
Copy link
Contributor

kulmann commented Jul 25, 2022

nice, thank you! 💪

@JammingBen JammingBen force-pushed the share-jail-followup branch from 57cde49 to d0a2728 Compare July 25, 2022 09:20
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

23.5% 23.5% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 3071ce0 into master Jul 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the share-jail-followup branch July 25, 2022 10:20
@JammingBen JammingBen mentioned this pull request Aug 3, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resharing. small findings
2 participants
@JammingBen @kulmann