[full-ci] Implement copy, cut, paste in ContextMenu | Fix nav icon flickering in lightmode

[lookacat]

Description

LocationPicker in Contextmenu is now replaced with clipboard actions (as already used with keyboard actions)
See #6892

What needs to be fixed in acceptance tests:

We've replaced the right-click contextmenu actions "copy" and "move", which opened the locationpicker, with clipboard actions. Now we have "cut", "copy" and "paste" instead and they should behave like e.g. in windows explorer.
Therefore we need to adjust how the tests copy or move files since the old way doesn't exist anymore.

Screenshots

Copy/paste keyboard shortcuts in contextmenu

Cutting elements "blurs" relevant resources / Paste becomes visible when there is an item in clipboard

Paste here button becomes visible if there are items in clipboard

Clipboard can be cleared by clicking close on the paste button (which also removes the paste here button)

Related Issue

• Works towards Copy/move only works with personal space #6892

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/27461/70/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIMoveFilesFolders-moveFiles_feature-L106.png

[kulmann]

I have mixed feelings about this PR. Feels like really good progress. But technically I don't like to see more and more in the vuex store... 🤔

[kulmann]

Had a glitch with what seems to be a prefix match issue. When I create two folders with names test and test2 on the same level, then copy test, navigate into test2 and try to paste I get an error message that I can't paste a folder into itself.

[lookacat]

@phil-davis @individual-it could someone from your team please take over required changes in the acceptance tests? :)

[SagarGi]

@lookacat @kulmann Some findings with this PR

1. After copying a specific file and selecting a destination folder to copy we have no cancel options to cancel copy as previouly.

(screenshot from master build)

need to know if its a feature or the X works as cancel in here?

2. And also we cannot copy paste in public link resources

cannotcopyinpubliclink.mp4

needs some information regarding this.

[kulmann]

1. After copying a specific file and selecting a destination folder to copy we have no cancel options to cancel copy as previouly.
   need to know if its a feature or the X works as cancel in here?

we don't need to test the cancel option anymore, as we don't navigate into a different view (location picker is obsolete with this PR). you just stay in the files list of any files related view. As a result you can delete tests that cancel the location picker.

2. And also we cannot copy paste in public link resources

cannotcopyinpubliclink.mp4

needs some information regarding this.

Needs to be fixed by a dev. Thanks for the pointer!

[kulmann]

@SagarGi

I added a fix for your second finding (pasting broken in public links) in 417f875

And in 6a9c79d I removed the location picker entirely, as it is not used anymore in the UI. There are some tests referencing the location picker. Some can be deleted (cancelling copy or move), but for some I'm not sure if you can rewrite them easily (anything that's successful copy/move e.g. from the personal page) or if the time would be better spent writing new ones in the e2e playwright tests and deleting them in the nightwatch test suite. What do you think?

[SagarGi]

@SagarGi

I added a fix for your second finding (pasting broken in public links) in 417f875

And in 6a9c79d I removed the location picker entirely, as it is not used anymore in the UI. There are some tests referencing the location picker. Some can be deleted (cancelling copy or move), but for some I'm not sure if you can rewrite them easily (anything that's successful copy/move e.g. from the personal page) or if the time would be better spent writing new ones in the e2e playwright tests and deleting them in the nightwatch test suite. What do you think?

@kulmann if location picker is entirely removed then tests related to it on (nightwatch) can be removed and time can be spent on e2e playwright for that as you say.

[SagarGi]

@kulmann i forgot to pull your changes from (#7309 (comment)) to my local and force push it (my very bad). So i have added them with commit 1b8cb5b and c541a9e

[kulmann]

@kulmann i forgot to pull your changes from (#7309 (comment)) to my local and force push it (my very bad). So i have added them with commit 1b8cb5b and c541a9e

No worries. Thanks for re-adding them. For future force pushes, just use git push --force-with-lease, that will abort the force push if the remote branch had changes in the meantime. Or just the shorthand gpf if you use https://ohmyz.sh

[kulmann]

@SagarGi
I added a fix for your second finding (pasting broken in public links) in 417f875
And in 6a9c79d I removed the location picker entirely, as it is not used anymore in the UI. There are some tests referencing the location picker. Some can be deleted (cancelling copy or move), but for some I'm not sure if you can rewrite them easily (anything that's successful copy/move e.g. from the personal page) or if the time would be better spent writing new ones in the e2e playwright tests and deleting them in the nightwatch test suite. What do you think?

@kulmann if location picker is entirely removed then tests related to it on (nightwatch) can be removed and time can be spent on e2e playwright for that as you say.

Cool. Thank you for already taking care! ❤️ I have removed some more dead code in the nightwatch test suite and moved the paste action from the location picker page object (deleted now) to the files list page object. Hope the test suite becomes green now :-)

[kulmann]

Awesome! 😍 The UX without the location picker is so much better, love it.

[SagarGi]

@SwikritiT @saw-jan @kiranparajuli589 may be someone can review the testscode changes.

[kulmann]

@SwikritiT @saw-jan @kiranparajuli589 may be someone can review the testscode changes.

I already did 😅 my review was for code and test-code. Looks all good to me 💪

[kulmann]

Temporarily converted back to draft because I want to get #7425 merged first. That one already had too many rebases...

[SagarGi]

@SwikritiT @saw-jan @kiranparajuli589 may be someone can review the testscode changes.

I already did sweat_smile my review was for code and test-code. Looks all good to me muscle

Thanks for if in that case.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells

33.0% Coverage
12.5% Duplication