Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set storageId to spaceId #7308

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Set storageId to spaceId #7308

merged 3 commits into from
Jul 21, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 21, 2022 •
edited
Loading

Description

Bugfix: "Shared with others" and "Shared via Link" page resource links not working

We've fixed a bug where resource links in "Shared with others" and "Shared via Link" page stopped working.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 21, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ownclouders
Copy link
Contributor

Results for oCISFavorites https://drone.owncloud.com/owncloud/web/26943/55/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 77a54ef into master Jul 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7303 branch July 21, 2022 10:13
@micbar micbar mentioned this pull request Aug 11, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shared with others / via link: parent-folder target shows "Resource not found"
3 participants
@AlexAndBear @ownclouders @kulmann