Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use id as fileId in space resource entities #7294

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Use id as fileId in space resource entities #7294

merged 1 commit into from
Jul 19, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 19, 2022 •
edited
Loading

Description

We're using the fileId of resources in various requests, but the space lacks a value in the fileId field. Fixed in this PR.

Also killed some dead method in the FileLinks.vue component.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jul 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JammingBen
JammingBen approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also works as expected 👍

@kulmann kulmann merged commit 4bd679b into master Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-personal-shares-in-project branch July 19, 2022 11:54
@kulmann kulmann mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@lookacat lookacat Awaiting requested review from lookacat

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@kulmann kulmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project space have public links from the personal space
2 participants
@kulmann @JammingBen