Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed keyboard up/down triggers scroll behaviour for no reason #7280

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Fixed keyboard up/down triggers scroll behaviour for no reason #7280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f3b563
Fixed keyboard up/down triggers scroll behaviour for no reason
lookacat Jul 15, 2022
9b2c1bd
Add to changelog, Linting
lookacat Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog/unreleased/enhancement-add-keyboard-navigation-selection
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ We've added the possibility to navigate and select via keyboard.
- via mouse holding shift + left click on a row: add the clicked row and the series of rows towards the most recently clicked row to the current selection model.

https://github.com/owncloud/web/pull/7153
https://github.com/owncloud/web/issues/6029
https://github.com/owncloud/web/issues/6029
https://github.com/owncloud/web/pull/7280
1 change: 1 addition & 0 deletions packages/web-app-files/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,6 @@ main {
#files-view {
grid-area: main;
z-index: 0;
outline: none;
}
</style>
2 changes: 2 additions & 0 deletions packages/web-app-files/src/components/FilesList/KeyboardActions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,14 @@ export default defineComponent({
}),

handleShortcut(event) {
event.preventDefault()
const key = event.keyCode || event.which
const ctrl = window.navigator.platform.match('Mac') ? event.metaKey : event.ctrlKey
const shift = event.shiftKey

this.handleFileActionsShortcuts(key, ctrl)
this.handleFileSelectionShortcuts(key, shift, ctrl, event)
document.getElementById(this.keybindOnElementId).focus()
},

handleFileActionsShortcuts(key, ctrl) {
Expand Down