Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Skip test on OCIS related to sharing #7246

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jul 8, 2022

Description

This PR skips the tests that were linked to the following closed issues:

The skipped tests are the ones that open the Shares folder using webUI check for resources or perform other actions. Since the implementation of Share jail the Shares folder is not available in personal, so this behavior is outdated for OCIS but relevant for OC10. Thus the tests are skipped in OCIS

Related Issue

Motivation and Context

Since we have decided that we won't be putting any effort into updating the Nightwatch tests, the tests that don't adhere with the current behavior of OCIS are skipped/removed.

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT force-pushed the skip-test-in-ocis branch from 00996f1 to f71abe1 Compare July 8, 2022 07:00
@ownclouders
Copy link
Contributor

ownclouders commented Jul 8, 2022

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/26741/62/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIResharing1-reshareUsers_feature-L194.png

webUIResharing1-reshareUsers_feature-L194.png

@SwikritiT SwikritiT force-pushed the skip-test-in-ocis branch from adb31d5 to 48f5017 Compare July 11, 2022 05:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScharfViktor please take a look if the approach suits you - I see the risk of deleting a lot of test cases that would be valid for oCIS also (but would need adaption since the share jail got merged)

@SwikritiT
Copy link
Contributor Author

@ScharfViktor please take a look if the approach suits you - I see the risk of deleting a lot of test cases that would be valid for oCIS also (but would need adaption since the share jail got merged)

I skipped these because I thought we were not going to update the tests in Nightwatch and these tests need to be updated in order for them to pass on Nightwatch for OCIS. I've mentioned the name of the scenario that is skipped in this PR here #6896 (comment) thinking that since the scenarios are already running in OC10 if we want to transfer it to playwright we can refer to the scenarios there. I can create a separate issue mentioning the complete scenarios skipped in this PR.

@ScharfViktor
Copy link
Contributor

@ScharfViktor please take a look if the approach suits you - I see the risk of deleting a lot of test cases that would be valid for oCIS also (but would need adaption since the share jail got merged)

I skipped these because I thought we were not going to update the tests in Nightwatch and these tests need to be updated in order for them to pass on Nightwatch for OCIS. I've mentioned the name of the scenario that is skipped in this PR here #6896 (comment) thinking that since the scenarios are already running in OC10 if we want to transfer it to playwright we can refer to the scenarios there. I can create a separate issue mentioning the complete scenarios skipped in this PR.

we agreed that we will not waste time for the old UI tests. we will close them but create a task to create new playwrigth tests

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me then if @ScharfViktor is happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants