Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quicklink action storageid retrieval #7243

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jul 7, 2022

with the recent integration of resharing for ocis we missed to update the quicklink creation action mixin.
This is fixed with a fallback chain to retrieve the corresponding storageid.

Fixes #7225

@fschade fschade added the Type:Bug Something isn't working label Jul 7, 2022
@fschade fschade requested a review from kulmann July 7, 2022 15:20
@fschade fschade requested a review from pascalwengerter as a code owner July 7, 2022 15:20
@update-docs
Copy link

update-docs bot commented Jul 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just now looking into the same issue and had the same solution 😅 thus approving. 👍

@kulmann
Copy link
Member

kulmann commented Jul 7, 2022

@fschade could you add the PR-link to your resharing changelog item?

@fschade fschade force-pushed the fix-quicklink-action-storageid branch from 619d78b to c006a85 Compare July 7, 2022 15:32
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@fschade fschade merged commit 3b7920c into master Jul 7, 2022
@kulmann kulmann deleted the fix-quicklink-action-storageid branch September 5, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User unknowingly shares personal space
2 participants