Add search nav item

[AlexAndBear]

Description

Related Issue

• Fixes Search: Left sidebar item is hard to read (because of wrong colors) #7190

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[pascalwengerter]

Love the simplification, and works nicely. Let's get this through CI and squash-merge 🕵🏽

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

27.8% Coverage
0.0% Duplication

[tbsbdr]

I don't get the userstory for this feature (new Item "Search" appears). I'd expect that there is no active sidebar item at all - first proposal of @kulmann s comment: #7190 (comment)

[AlexAndBear]

Well this was spoken with @kulmann which we found a good idea, easy to remove anyways if you wish so.

[tbsbdr]

If I'm not missing something we should not have an additional Item ( remove it) and follow Benedikts first proposal -> have no item at all for search in the left sidebar as I guess this is the users expectation (looking at eg. webmail clients or competitors). We can wait until Benedikt is back - maybe I miss something...

[AlexAndBear]

Let's remove it, but the issue is not solved then, nav highlighter is still behaving strange

[AlexAndBear]

#7270