Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Using plugins/s3-cache:1 instead of meltwater/drone-cache:v1 #7209

Merged
merged 2 commits into from
Jul 7, 2022
Merged

[full-ci] [tests-only] Using plugins/s3-cache:1 instead of meltwater/drone-cache:v1 #7209

merged 2 commits into from
Jul 7, 2022

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Jul 4, 2022 •
edited
Loading

Description

This PR updates the image meltwater/drone-cache:v1 to official S3 cache plugin plugins/s3-cache:1.

Changes done in .drone.star:

  1. Used official S3 cache plugin image plugins/s3-cache:1 for cache rebuild, restore, and purge instead of meltwater/drone-cache:v1 image
  2. Refactored the steps settings configuration as per the S3 cache plugin

Related Issue

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup changed the title [full-ci] Using plugins/s3-cache:1 instead of meltwater/drone-cache:v1 [full-ci] [tests-only] Using plugins/s3-cache:1 instead of meltwater/drone-cache:v1 Jul 4, 2022
@grgprarup grgprarup self-assigned this Jul 4, 2022
@grgprarup grgprarup force-pushed the refactor-drone-file branch 3 times, most recently from 9881ea6 to a216249 Compare July 5, 2022 08:34
@pascalwengerter
Copy link
Contributor

Looks like this needs additional configuration, see rebuild_yarn_build_artifact_cache in https://drone.owncloud.com/owncloud/web/26661/6/4 (can't take more than a few seconds)

@grgprarup grgprarup force-pushed the refactor-drone-file branch 2 times, most recently from f8258a1 to 13a2fdf Compare July 6, 2022 05:05
@grgprarup grgprarup force-pushed the refactor-drone-file branch from 13a2fdf to e2a3f0a Compare July 6, 2022 06:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@grgprarup grgprarup marked this pull request as ready for review July 6, 2022 07:50
kiranparajuli589
kiranparajuli589 reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

SwikritiT
SwikritiT reviewed Jul 7, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owncloud owncloud deleted a comment from update-docs bot Jul 7, 2022
@phil-davis phil-davis merged commit 9f944c7 into master Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-drone-file branch July 7, 2022 04:54
This was referenced Jul 7, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@individual-it individual-it Awaiting requested review from individual-it

@sushmita56 sushmita56 Awaiting requested review from sushmita56

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use official S3 cache plugin in drone instead of meltwater/drone-cache:v1
5 participants
@grgprarup @pascalwengerter @phil-davis @kiranparajuli589 @SwikritiT