Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of share indicators #7188

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jun 28, 2022

Description

We've improved the performance of share indicators when loading resource tables as well as when adding or removing shares.

In detail:

  • Accessing a shared folder: The share indicators now get loaded initially with the resources. The store then gets updated once, including all indicators. Before, the store was updated after the initial load. Also, this happened for each resource, resulting in a re-render of each table row.
  • Creating shares & public links: Instead of loading share indicators for all resources in the store, we now only load those for the current file (and files inside a folder).

Related Issue

Performance measurements

Tests were done with a shared folder including 800 files. Note that the measured time is generally longer when the measurement tool is running. This means the tool is fine for a before- & after-comparison, but not for evaluating the total time as it would be much faster without the measurement.

Accessing the folder:

Without optimization (~ 8,5 s):

Pasted Graphic 1

With optimization (~ 6,5 s):

Pasted Graphic

Creating a public link for a resource within the folder:

Without optimization (~ 11 s):

image

With optimization (~ 6,5 s):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 28, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Jun 28, 2022

Results for oC10SharingSharingInd https://drone.owncloud.com/owncloud/web/26490/33/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroupsSharingIndicator-shareWithGroups_feature-L136.png

webUISharingInternalGroupsSharingIndicator-shareWithGroups_feature-L136.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups_feature-L124.png

webUISharingInternalGroupsToRootSharingIndicator-shareWithGroups_feature-L124.png

webUISharingInternalUsersSharingIndicator-shareWithUsers_feature-L17.png

webUISharingInternalUsersSharingIndicator-shareWithUsers_feature-L17.png

webUISharingInternalUsersToRootSharingIndicator-shareWithUsers_feature-L118.png

webUISharingInternalUsersToRootSharingIndicator-shareWithUsers_feature-L118.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the share-indicator-performance branch 2 times, most recently from afcaa4c to 4926bfe Compare June 28, 2022 11:41
@JammingBen JammingBen changed the title Improve performance when loading share inidicators Improve performance of share indicators Jun 28, 2022
@JammingBen JammingBen force-pushed the share-indicator-performance branch from 4926bfe to ed1b7b7 Compare June 28, 2022 13:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

7.1% 7.1% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review June 28, 2022 13:48
@JammingBen JammingBen requested a review from kulmann June 28, 2022 13:48
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jun 28, 2022
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@kulmann kulmann merged commit ddb4624 into master Jun 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the share-indicator-performance branch June 30, 2022 08:45
@JammingBen JammingBen removed the Status:Needs-Review Needs review from a maintainer label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants