Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blocking file extensions of text-editor #7174

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 23, 2022

Description

Allow to block file extensions of the text-editor app

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested review from diocas and elizavetaRa June 23, 2022 08:45
@kulmann kulmann self-assigned this Jun 23, 2022
@kulmann
Copy link
Member Author

kulmann commented Jun 23, 2022

I've added the docs to the oc10 deployment section because that one already has such a section. But for the text-editor it works the same way for ocis.

@diocas
Copy link
Contributor

diocas commented Jun 23, 2022

It would be great to be able to disable the default opening + creation, while keeping the possibility to open a file with the editor, but I think is good enough for now. (I just realized that I mention "opening" instead of "default opening" in #6661...)

packages/web-app-text-editor/src/index.js Outdated Show resolved Hide resolved
packages/web-app-text-editor/src/index.js Outdated Show resolved Hide resolved
@kulmann kulmann force-pushed the text-editor-config-skip-file-extensions branch from 7705420 to 06d8d6e Compare June 30, 2022 15:59
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit b90e3c7 into master Jul 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the text-editor-config-skip-file-extensions branch July 1, 2022 13:47
ownclouders pushed a commit that referenced this pull request Jul 1, 2022
Author: Benedikt Kulmann <[email protected]>
Date:   Fri Jul 1 15:47:24 2022 +0200

    Allow blocking file extensions of text-editor (#7174)

    Allow changing primary file extensions for text editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants