Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External apps fixes #7166

Closed
wants to merge 4 commits into from
Closed

Conversation

diocas
Copy link
Contributor

@diocas diocas commented Jun 22, 2022

#6870 brought a couple of issues.. One, is that external apps extension is completely broken, because makeRequest was moved to a different place and never imported into defaultApps.
The second is that the behavior of the method has also changed. (Draw.io is still broken when importing visio files).

The other - not as important - regression is that the app name no longer appears in the title.

@update-docs
Copy link

update-docs bot commented Jun 22, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann added Type:Bug Something isn't working Priority:p1-urgent Consider a hotfix release with only that fix labels Jun 22, 2022
@diocas diocas force-pushed the up/external_apps_fix branch from 84b29dd to 715e980 Compare June 22, 2022 19:27
@diocas diocas force-pushed the up/external_apps_fix branch from 715e980 to bb5a42e Compare June 22, 2022 19:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann mentioned this pull request Jun 23, 2022
9 tasks
@kulmann
Copy link
Member

kulmann commented Jun 23, 2022

Hey, thank you for this fix! That's actually blocking the ocis beta.4 release because, as you mentioned, wopi server usage in web is completely broken.
I took the liberty of taking over your PR in #7173 because I was not completely happy with the code duplication for the app name in the document title. I added an option to override the app name in the composable and use it in the App.vue of the external app, instead of your usage in the mounted hook. Hope this is ok.

@kulmann kulmann closed this Jun 23, 2022
@diocas diocas deleted the up/external_apps_fix branch June 23, 2022 08:37
@micbar micbar mentioned this pull request Jul 19, 2022
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early-Adopter:CERN Priority:p1-urgent Consider a hotfix release with only that fix Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants