Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload (performance) improvements round 2 #7127

Merged
merged 6 commits into from
Jun 20, 2022
Merged

Upload (performance) improvements round 2 #7127

merged 6 commits into from
Jun 20, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jun 14, 2022 •
edited
Loading

Description

  • Prevent all uploaded root-folders from being fetched one by one. Instead, reload the filelist in the end
  • Use uppy.addFiles() instead of calling uppy.addFile() for each file
  • Fixed a bug with the upload time estimation when uploading many files
  • Improved user feedback of the upload overlay during upload preparation
  • Temporarily disabled uploadDataDuringCreation to prevent the local storage from getting to full
  • Some more refactoring under the hood has been made

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jun 14, 2022
@owncloud owncloud deleted a comment from update-docs bot Jun 15, 2022
@JammingBen JammingBen force-pushed the upload-performance-v2 branch from d97c54a to f656ae0 Compare June 15, 2022 13:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 4 Code Smells

73.1% 73.1% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen changed the title [WIP] Upload performance improvements round 2 Upload (performance) improvements round 2 Jun 15, 2022
@JammingBen JammingBen marked this pull request as ready for review June 15, 2022 13:40
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jun 15, 2022
@JammingBen JammingBen requested a review from kulmann June 15, 2022 13:40
@kulmann kulmann mentioned this pull request Jun 20, 2022
Closed
25 tasks
pascalwengerter
pascalwengerter approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM, checking it out locally now:)

pascalwengerter
pascalwengerter approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed works like a charm, dockerized oc10 is way faster than current oCIS started from binary (but I don't think that's a frontend issue)

@pascalwengerter pascalwengerter merged commit b28fb0e into master Jun 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the upload-performance-v2 branch June 20, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload-overlay is slow and not robust
3 participants
@JammingBen @kulmann @pascalwengerter