Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Upload progress & overlay improvements #7067

Merged
merged 12 commits into from
Jun 7, 2022
Merged

[full-ci] Upload progress & overlay improvements #7067

merged 12 commits into from
Jun 7, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented May 30, 2022 •
edited
Loading

Description

  • Remove fetching of newly uploaded files to improve performance
  • Redesign the upload overlay
  • Show currently uploading files in the upload overlay
  • Immediately show the upload overlay when uploading folders to tell the user that the upload is starting
  • Only show top level folders in the upload overlay when uploading folders
  • Remove the Uppy StatusBar plugin

Images

image

image

image

image

image

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 30, 2022
@JammingBen JammingBen changed the title [WIP] Upload performance improvements [WIP] Upload progress & overlay improvements Jun 1, 2022
@owncloud owncloud deleted a comment from update-docs bot Jun 1, 2022
@JammingBen JammingBen force-pushed the upload-performance branch from c064db6 to e8e6b27 Compare June 1, 2022 12:22
@ownclouders
Copy link
Contributor

ownclouders commented Jun 1, 2022 •
edited
Loading

Results for oC10Resharing https://drone.owncloud.com/owncloud/web/26055/23/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIResharing2-reshareUsers_feature-L29.png

webUIResharing2-reshareUsers_feature-L29.png

@JammingBen JammingBen changed the title [WIP] Upload progress & overlay improvements Upload progress & overlay improvements Jun 1, 2022
@JammingBen JammingBen force-pushed the upload-performance branch from 6f513a0 to f7d2285 Compare June 2, 2022 08:18
@JammingBen JammingBen changed the title Upload progress & overlay improvements [full-ci] Upload progress & overlay improvements Jun 2, 2022
@JammingBen JammingBen force-pushed the upload-performance branch from 961ac2f to 3d2096a Compare June 2, 2022 12:35
@JammingBen
Copy link
Contributor Author

I removed tests in https://github.com/owncloud/web/pull/7067/files#diff-7ff753fa67024c025ec8b0664b74f47dc3c2ca9e322df27ebccb19045b421339 because we would need to write new steps, which is something for e2e tests in the future I believe.

@JammingBen JammingBen marked this pull request as ready for review June 2, 2022 13:09
@JammingBen JammingBen requested a review from kulmann June 2, 2022 13:10
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Jun 2, 2022
@kulmann kulmann mentioned this pull request Jun 3, 2022
Closed
25 tasks
@kulmann
Copy link
Contributor

kulmann commented Jun 7, 2022

@JammingBen could you rebase this PR please? there are some conflicted files

@JammingBen JammingBen force-pushed the upload-performance branch from 3d2096a to e8a273c Compare June 7, 2022 08:03
pascalwengerter
pascalwengerter reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Added small UI/markup suggestions, seems to work like a charm (and I've restarted CI which failed with a middleware-startup-timeout)

packages/web-runtime/src/components/UploadInfo.vue
size="small"
/>
<oc-icon v-else-if="item.status === 'cancelled'" name="close" size="small" />
<oc-icon v-else-if="uploadsPaused" name="pause" size="small" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like the "pause" icon for paused uploads (esp. since we use it as a "click here to pause" button in the same component), but not sure if we have a better one (except for maybe the file/folder icon of the resource?)

Screenshot 2022-06-07 at 10-43-43 New folder - Personal - ownCloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbsbdr What do you think? We could keep displaying the loading wheel during pause.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated: the folder icon looks rather big here 😅

pascalwengerter
pascalwengerter reviewed Jun 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have checked this earlier sry, just found this glitch on mobile 😬

Screenshot 2022-06-07 at 14-12-34 Personal - ownCloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

19.5% 19.5% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@kulmann kulmann merged commit b49e3d2 into master Jun 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the upload-performance branch June 7, 2022 14:28
This was referenced Jun 8, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload progress/completion widget should only show the uploaded items
4 participants
@JammingBen @ownclouders @kulmann @pascalwengerter