Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove private links from share notifications #6955

Merged
merged 1 commit into from
May 12, 2022
Merged

Remove private links from share notifications #6955

merged 1 commit into from
May 12, 2022

Conversation

JammingBen
Copy link
Contributor

Description

As described in #5227 (comment).

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 12, 2022
@JammingBen JammingBen requested a review from fschade as a code owner May 12, 2022 11:46
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe needs to be adjusted for alias links down the road, but looks solid!

@JammingBen JammingBen merged commit 66ce764 into master May 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-link-from-share-notification branch May 12, 2022 12:21
@kulmann kulmann mentioned this pull request May 25, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File link in notifications seems to not work
2 participants
@JammingBen @pascalwengerter