Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6917 - sharing indicators&description for spaces #6921

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

pascalwengerter
Copy link
Contributor

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's displayed correctly, but the share labels got mixed up 😄

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

19.2% 19.2% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/25438/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUICreateFilesFolders-createFile_feature-L31.png

webUICreateFilesFolders-createFile_feature-L31.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter pascalwengerter changed the title Fix 6917 Fix #6917 - sharing indicators&description for spaces Jun 15, 2022
@pascalwengerter pascalwengerter requested a review from kulmann June 17, 2022 10:17
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

23.1% 23.1% Coverage
0.0% 0.0% Duplication

</td>
</tr>
</table>
<div v-if="hasShares" class="oc-flex oc-flex-middle oc-mb-m oc-text-small" style="gap: 15px">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor finding, inline style :)

@pascalwengerter pascalwengerter merged commit 6fb3d5b into master Jun 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-6917 branch June 27, 2022 07:46
@micbar micbar mentioned this pull request Jul 19, 2022
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link sharing indicator for spaces is not working
4 participants