Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load spaces on startup if not in capabilties #6912

Merged
merged 1 commit into from
May 9, 2022
Merged

Don't load spaces on startup if not in capabilties #6912

merged 1 commit into from
May 9, 2022

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented May 9, 2022 •
edited
Loading

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/25428/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesList-fileList_feature-L33.png

webUIFilesList-fileList_feature-L33.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear
Copy link
Contributor Author

@kulmann can I get a force merge?

@kulmann kulmann merged commit 1ce8317 into master May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the dont-load-spaces-on-startup-if-not-present-in-capabilities branch May 9, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @ownclouders @kulmann @pascalwengerter