Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several issues when setting image and readme for spaces #6898

Merged
merged 3 commits into from
May 9, 2022
Merged

Fix several issues when setting image and readme for spaces #6898

merged 3 commits into from
May 9, 2022

Conversation

JammingBen
Copy link
Contributor

Description

  • An issue where setting a space-image or -readme would corrupt the file list has been fixed.
  • Setting images from within the .space folder has been fixed.
  • Setting images and readme files with specials characters in their names has been fixed.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this May 6, 2022
@ownclouders
Copy link
Contributor

ownclouders commented May 6, 2022 •
edited
Loading

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/25397/66/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L49.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L52.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen force-pushed the fix-space-image-readme-issues branch from b8ac88c to bc7d920 Compare May 6, 2022 14:21
@JammingBen JammingBen marked this pull request as ready for review May 6, 2022 14:33
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label May 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.5% 76.5% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 716a475 into master May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-space-image-readme-issues branch May 9, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nothing happens when you press button "set as space image"
3 participants
@JammingBen @ownclouders @kulmann