Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor upload inputs into one component #6859

Merged
merged 5 commits into from
May 5, 2022
Merged

Refactor upload inputs into one component #6859

merged 5 commits into from
May 5, 2022

Conversation

JammingBen
Copy link
Contributor

Description

Continuation of #6202

Related Issue

@JammingBen JammingBen self-assigned this May 3, 2022
@JammingBen JammingBen mentioned this pull request May 3, 2022
Closed
10 tasks
@owncloud owncloud deleted a comment from update-docs bot May 3, 2022
@JammingBen JammingBen marked this pull request as ready for review May 3, 2022 10:20
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label May 3, 2022
@JammingBen JammingBen force-pushed the resource-upload-component branch from 8412b61 to 4de6265 Compare May 3, 2022 10:57
@ownclouders
Copy link
Contributor

ownclouders commented May 3, 2022 •
edited
Loading

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/25297/18/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesList-fileList_feature-L28.png

webUIFilesList-fileList_feature-L28.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen removed the Status:Needs-Review Needs review from a maintainer label May 3, 2022
@JammingBen JammingBen force-pushed the resource-upload-component branch from 4de6265 to 5caa404 Compare May 3, 2022 12:20
kulmann
kulmann approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@JammingBen JammingBen force-pushed the resource-upload-component branch 2 times, most recently from 2415135 to 5291274 Compare May 4, 2022 07:33
@JammingBen JammingBen force-pushed the resource-upload-component branch from 5291274 to 6ecc34d Compare May 4, 2022 11:55
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 80195d8 into master May 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the resource-upload-component branch May 5, 2022 07:33
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt dschmidt approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JammingBen @ownclouders @dschmidt @kulmann @pascalwengerter