Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Remove hideSearchBar config option in favor of capabilities #6856

Merged
merged 2 commits into from
May 3, 2022
Merged

[full-ci] Remove hideSearchBar config option in favor of capabilities #6856

merged 2 commits into from
May 3, 2022

Conversation

pascalwengerter
Copy link
Contributor

Description

We should debate if we really want to remove this (e.g. think of ownBrander) before merging

Related Issue

@pascalwengerter pascalwengerter requested a review from fschade as a code owner May 2, 2022 22:11
@update-docs
Copy link

update-docs bot commented May 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter force-pushed the capability-based-searchbar branch from 533e832 to 95afd68 Compare May 2, 2022 22:16
@pascalwengerter pascalwengerter requested a review from kulmann May 2, 2022 22:22
@ownclouders
Copy link
Contributor

ownclouders commented May 2, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25138/68/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkEdit.feature:58

@pascalwengerter
Copy link
Contributor Author

@kulmann could be force-merged since it failed with an unrelated false positive in the acceptance tests in https://drone.owncloud.com/owncloud/web/25136. I'll use the PR to update some minor dependencies, too

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann reviewed May 3, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about hiding the search field if no search providers are available?

@kulmann kulmann merged commit 53ddc5a into master May 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the capability-based-searchbar branch May 3, 2022 18:45
ownclouders pushed a commit that referenced this pull request May 3, 2022
@kulmann
commit 53ddc5a
4b53001 
Merge: 4d0b216 b4457b8
Author: Benedikt Kulmann <[email protected]>
Date:   Tue May 3 20:45:24 2022 +0200

    Merge pull request #6856 from owncloud/capability-based-searchbar

    [full-ci] Remove hideSearchBar config option in favor of capabilities
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of hideSearchBar option by using existing capability
3 participants
@pascalwengerter @ownclouders @kulmann