Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root folder links in the upload overlay #6846

Merged
merged 3 commits into from
May 4, 2022
Merged

Fix root folder links in the upload overlay #6846

merged 3 commits into from
May 4, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Apr 29, 2022 •
edited
Loading

Description

We've fixed a bug where the folder links in the upload overlay were broken when navigating into another app or file list.

Follow up for #6202

Related Issue

@JammingBen JammingBen self-assigned this Apr 29, 2022
@JammingBen JammingBen mentioned this pull request Apr 29, 2022
Closed
10 tasks
@JammingBen JammingBen force-pushed the fix-upload-overlay-folder-links branch from 3d5ba3a to 0722a40 Compare May 2, 2022 07:37
@owncloud owncloud deleted a comment from update-docs bot May 2, 2022
@ownclouders
Copy link
Contributor

ownclouders commented May 2, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25202/68/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkEdit.feature:57
    💥 The acceptance tests pipeline failed. The build has been cancelled.

@JammingBen JammingBen marked this pull request as ready for review May 2, 2022 08:21
@JammingBen JammingBen requested review from dschmidt and kulmann May 2, 2022 08:21
@JammingBen JammingBen force-pushed the fix-upload-overlay-folder-links branch 5 times, most recently from 44ddd93 to 6340bfc Compare May 3, 2022 06:53
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label May 3, 2022
@dschmidt
Copy link
Member

dschmidt commented May 3, 2022

likely needs rebase on #6853

@JammingBen JammingBen force-pushed the fix-upload-overlay-folder-links branch 2 times, most recently from dc14616 to bcf6dda Compare May 3, 2022 12:21
@JammingBen JammingBen requested a review from dschmidt May 3, 2022 12:52
@JammingBen JammingBen force-pushed the fix-upload-overlay-folder-links branch from bcf6dda to 3f22725 Compare May 3, 2022 14:27
kulmann
kulmann approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. CI is unhappy though

@JammingBen JammingBen force-pushed the fix-upload-overlay-folder-links branch from 3f22725 to f244550 Compare May 4, 2022 07:33
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

7.7% 7.7% Coverage
9.5% 9.5% Duplication

@JammingBen JammingBen merged commit c7ca5d4 into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-upload-overlay-folder-links branch May 4, 2022 09:53
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
@kulmann kulmann mentioned this pull request May 25, 2022
Closed
25 tasks
@micbar micbar mentioned this pull request Jun 22, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees

@JammingBen JammingBen

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JammingBen @ownclouders @dschmidt @kulmann