Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Remove the upload progress bar and its related states #6825

Merged
merged 6 commits into from
May 4, 2022
Merged

[full-ci] Remove the upload progress bar and its related states #6825

merged 6 commits into from
May 4, 2022

Conversation

JammingBen
Copy link
Contributor

Description

Continuation of #6202

Related Issue

@JammingBen JammingBen self-assigned this Apr 28, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Apr 28, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25284/68/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkEdit.feature:60

@JammingBen JammingBen mentioned this pull request Apr 28, 2022
Closed
10 tasks
@JammingBen JammingBen changed the title Remove the upload progress bar and its related states [full-ci] Remove the upload progress bar and its related states Apr 28, 2022
@owncloud owncloud deleted a comment from update-docs bot Apr 28, 2022
@pascalwengerter
Copy link
Contributor

Not sure if that's wanted since copying/moving files also relies on the progress bar?

@kulmann
Copy link
Member

kulmann commented Apr 28, 2022

Not sure if that's wanted since copying/moving files also relies on the progress bar?

Afaik those two are ui-blocking actions without any visual progress at the moment (hopefully not for long anymore, but that's the current state).

@pascalwengerter
Copy link
Contributor

Not sure if that's wanted since copying/moving files also relies on the progress bar?

Afaik those two are ui-blocking actions without any visual progress at the moment (hopefully not for long anymore, but that's the current state).

I could've sworn that this was the case at some point, but from trying on current master and checking the code you're probably right...

@JammingBen
Copy link
Contributor Author

@saw-jan Could you maybe have a look why the test in https://drone.owncloud.com/owncloud/web/24975/42/28 is failing? I can't get it to run locally, the step And the setting "auto_accept_trusted" of app "federatedfilesharing" has been set to "no" on remote server always failes with Error: TypeError: Only absolute URLs are supported.

@JammingBen JammingBen force-pushed the remove-progress-bar branch from e74a9d0 to 8efc3a0 Compare April 29, 2022 07:05
@pascalwengerter
Copy link
Contributor

Rebased on current web master, happy to merge if it passes CI now 😬

@JammingBen
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/web/25137/68/15 fails because of the changes in this PR, but I can't get this acceptance test to run locally 😞

@pascalwengerter
Copy link
Contributor

@individual-it could you put this on your team's schedule with a medium-level priority? :)

@saw-jan saw-jan self-assigned this May 4, 2022
@saw-jan saw-jan force-pushed the remove-progress-bar branch from 2a31006 to 2881479 Compare May 4, 2022 09:33
@saw-jan
Copy link
Member

saw-jan commented May 4, 2022

@JammingBen I have pushed the fix
The main problem was that the file checking occurred before the file upload was successful (in failing federation tests)
And other failing tests are intermittent I guess.
Rebased the PR with master

@JammingBen
Copy link
Contributor Author

Thank you!

And other failing tests are intermittent I guess.

Yeah, the pipeline in general has a lot of issues this week. Not related to this specific PR though.

@JammingBen JammingBen marked this pull request as ready for review May 4, 2022 09:45
@JammingBen JammingBen requested a review from fschade as a code owner May 4, 2022 09:45
@saw-jan saw-jan force-pushed the remove-progress-bar branch from 2881479 to c31460d Compare May 4, 2022 10:22
@saw-jan
Copy link
Member

saw-jan commented May 4, 2022 •
edited
Loading

Updated oc10 expected failure file

NOTE: CI failing due to known intermittent fails (not related to this PR)

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit 4e9aa0b into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-progress-bar branch May 4, 2022 13:25
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

@saw-jan saw-jan

Labels
QA:p2 QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JammingBen @ownclouders @pascalwengerter @kulmann @saw-jan @individual-it