[full-ci] Introduce QuickLinks #6820

pascalwengerter · 2022-04-27T13:21:25Z

Related Issue

Fixes Scoped links: Quick link #6605
Fixes Unite "Links" + "People" in "Share" Panel #6621

To-Do's

Fix SDK problem between quicklink creation in OC10 vs oCIS
Fix color & spacing on CreateQuickLinks.vue
Fix animation for copying links to clipboard
Add/adjust unit tests for link sidebar share components
Fix acceptance tests for copying quicklinks through quickactions/contextmenu

Includes an SDK bump ~~Needs a local link to owncloud/owncloud-sdk#1042 (and the SDK PR merged and released with an SDK bump to get this PR to master)~~

update-docs · 2022-04-27T13:21:28Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter · 2022-04-29T14:20:00Z

packages/web-app-files/tests/unit/components/SideBar/Links/PrivateLinkItem.spec.js

@@ -1,77 +0,0 @@
-import Vuex from 'vuex'


We had this file twice after some directory restructuring and rebase I guess

ownclouders · 2022-05-02T09:12:21Z

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25288/68/1
The following scenarios passed on retry:

webUISharingPublicBasic/publicLinkEdit.feature:57

pascalwengerter · 2022-05-02T22:23:03Z

@kulmann could you check regarding code quality, a11y and UX? :)

kulmann

Works like a charm 🥳 few remarks added. I guess when you decided on how to handle the test suite, this should be good to merge.

packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue

packages/web-app-files/src/components/SideBar/Shares/Links/CreateQuickLink.vue

kulmann · 2022-05-03T08:39:27Z

packages/web-runtime/src/store/config.js

+    homeFolder: '',
+    sidebar: {
+      shares: {
+        showAllOnLoad: false


Please also add this to the getting started docs page, which lists all available options.

kulmann · 2022-05-03T08:40:27Z

dev/docker/oc10.config.php

@@ -2,5 +2,6 @@
 $CONFIG = [
    'web.baseUrl' => 'http://host.docker.internal:8080/index.php/apps/web',
    'web.rewriteLinks' => true,
+    'sharing.showPublicLinkQuickAction' => true,


dev leftover or intended change to our dev setup?

Had the same questions, was reluctant to commit it but @fschade went ahead. I get the reasoning though and would leave it in our dev setup since otherwise we'd fall back to internal pings about "how to get it work" which is suboptimal

i would keep it, this enables the same quicklink behavior for oc10 as in ocis...

pascalwengerter · 2022-05-03T12:41:34Z

packages/web-app-files/tests/unit/components/SideBar/Shares/FileShares.spec.js

@@ -78,19 +77,6 @@ describe('FileShares', () => {
      expect(wrapper).toMatchSnapshot()
    })

-    it('can toggle the collaborators list by clicking the avatar wrapper button', async () => {


We should actually re-write the test because toggling is still available, just with a different logic :)

first ruff implementation for quicklinks combine CURRENT_FILE_OUTGOING_SHARES_ADD and CURRENT_FILE_OUTGOING_SHARES_UPDATE into CURRENT_FILE_OUTGOING_SHARES_UPSERT refactor quicklink action into helper implement quicklink logic update test message text

…sidebar

Minor styling & unit test fixes Restrict link renaming for quicklink

fix currentRole in createForm add oc10 docker dev config to enable quicklinks fix resource quicklink detection Add SDK bump changelog && fix fault accessing of sidebar config option get rid uf obsolete collaborator unit test fix oc10 resource quicklink attribute detection fix failing acceptance tests

pascalwengerter · 2022-05-04T13:15:17Z

webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:49 passes locally, webUISharingPublicBasic/publicLinkEdit.feature:57 is known to be flaky. Restarting CI

sonarcloud · 2022-05-04T13:27:55Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

57.5% Coverage
0.0% Duplication

kulmann · 2022-05-04T14:28:34Z

webUISharingPublicBasic/publicLinkEdit.feature:57 failed in the last CI run. Known to be flaky, I'll force-merge.

pascalwengerter force-pushed the introduce-quicklinks branch from f21473c to da4c9e3 Compare April 28, 2022 13:34

kulmann mentioned this pull request Apr 29, 2022

Release 5.5.0 #6812

Closed

25 tasks

pascalwengerter force-pushed the introduce-quicklinks branch from 8c94b91 to 5fc1027 Compare April 29, 2022 13:30

pascalwengerter commented Apr 29, 2022

View reviewed changes

pascalwengerter changed the title ~~Introduce QuickLinks~~ [full-ci] Introduce QuickLinks May 2, 2022

pascalwengerter marked this pull request as ready for review May 2, 2022 21:15

pascalwengerter requested a review from fschade as a code owner May 2, 2022 21:15

pascalwengerter requested a review from kulmann May 2, 2022 22:22

kulmann mentioned this pull request May 3, 2022

[full-ci] Sharing jail #6593

Merged

30 tasks

kulmann reviewed May 3, 2022

View reviewed changes

pascalwengerter force-pushed the introduce-quicklinks branch from a08cad0 to cbf308f Compare May 3, 2022 12:17

pascalwengerter commented May 3, 2022

View reviewed changes

pascalwengerter force-pushed the introduce-quicklinks branch from 9670449 to 571c817 Compare May 3, 2022 14:33

kulmann approved these changes May 4, 2022

View reviewed changes

pascalwengerter force-pushed the introduce-quicklinks branch 2 times, most recently from 5dfdf02 to 2e763c7 Compare May 4, 2022 12:38

pascalwengerter and others added 6 commits May 4, 2022 14:39

WIP init revert

1c9aee2

first ruff implementation for quicklinks combine CURRENT_FILE_OUTGOING_SHARES_ADD and CURRENT_FILE_OUTGOING_SHARES_UPDATE into CURRENT_FILE_OUTGOING_SHARES_UPSERT refactor quicklink action into helper implement quicklink logic update test message text

Split copyLinkToClipBoard for public&private link, add quicklinks to …

d50763c

…sidebar

Add quicklink compatibility for oc10, changelog item

04404e8

Minor styling & unit test fixes Restrict link renaming for quicklink

Add graph env var to dockerized oCIS middleware

ad1f15d

Add toggles to sidebar sharee/link lists

72fba44

kulmann merged commit f3a39d0 into master May 4, 2022

delete-merged-branch bot deleted the introduce-quicklinks branch May 4, 2022 14:28

pascalwengerter mentioned this pull request May 5, 2022

Add docs for sidebar.shares.showAllOnLoad configuration option #6883

Merged

micbar mentioned this pull request May 5, 2022

Release 2.0.0-beta1 owncloud/ocis#3627

Closed

45 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Introduce QuickLinks #6820

[full-ci] Introduce QuickLinks #6820

pascalwengerter commented Apr 27, 2022 •

edited

Loading

update-docs bot commented Apr 27, 2022

pascalwengerter Apr 29, 2022

ownclouders commented May 2, 2022 •

edited

Loading

pascalwengerter commented May 2, 2022

kulmann left a comment

kulmann May 3, 2022

kulmann May 3, 2022

pascalwengerter May 3, 2022

fschade May 3, 2022

pascalwengerter May 3, 2022

pascalwengerter commented May 4, 2022

sonarcloud bot commented May 4, 2022

kulmann commented May 4, 2022

[full-ci] Introduce QuickLinks #6820

[full-ci] Introduce QuickLinks #6820

Conversation

pascalwengerter commented Apr 27, 2022 • edited Loading

Related Issue

To-Do's

update-docs bot commented Apr 27, 2022

pascalwengerter Apr 29, 2022

Choose a reason for hiding this comment

ownclouders commented May 2, 2022 • edited Loading

pascalwengerter commented May 2, 2022

kulmann left a comment

Choose a reason for hiding this comment

kulmann May 3, 2022

Choose a reason for hiding this comment

kulmann May 3, 2022

Choose a reason for hiding this comment

pascalwengerter May 3, 2022

Choose a reason for hiding this comment

fschade May 3, 2022

Choose a reason for hiding this comment

pascalwengerter May 3, 2022

Choose a reason for hiding this comment

pascalwengerter commented May 4, 2022

sonarcloud bot commented May 4, 2022

kulmann commented May 4, 2022

pascalwengerter commented Apr 27, 2022 •

edited

Loading

ownclouders commented May 2, 2022 •

edited

Loading