Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Design polishing v3 #6781

Merged
merged 7 commits into from
Apr 29, 2022
Merged

[full-ci] Design polishing v3 #6781

merged 7 commits into from
Apr 29, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 12, 2022 •
edited
Loading

Description

See #6555

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests updated
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 12, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

kulmann
kulmann requested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the state of this PR? There are two small improvements in this PR, makes sense to finish it, get it merged and tackle other design polishing fixes in separate PRs?

packages/web-app-files/src/components/SideBar/Shares/SpaceMembers.vue Outdated Show resolved Hide resolved
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue Outdated Show resolved Hide resolved
...es/src/components/SideBar/Shares/Collaborators/InviteCollaborator/InviteCollaboratorForm.vue Outdated Show resolved Hide resolved
@lookacat
Copy link
Contributor Author

@kulmann yes will take over the branch again

@lookacat lookacat force-pushed the design-polishing-v4 branch 3 times, most recently from c83ba24 to 71df8df Compare April 25, 2022 09:10
@lookacat lookacat marked this pull request as ready for review April 25, 2022 09:13
@lookacat lookacat requested a review from kulmann April 25, 2022 09:13
@lookacat lookacat force-pushed the design-polishing-v4 branch from 4a71748 to 608cab8 Compare April 28, 2022 08:28
@lookacat lookacat requested a review from kulmann April 28, 2022 09:07
@lookacat lookacat force-pushed the design-polishing-v4 branch from e612378 to 6079900 Compare April 28, 2022 09:18
@lookacat lookacat requested a review from kulmann April 28, 2022 09:19
@lookacat lookacat force-pushed the design-polishing-v4 branch 2 times, most recently from 630fd82 to 13b5368 Compare April 28, 2022 09:27
kulmann
kulmann approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann
Copy link
Member

kulmann commented Apr 28, 2022

To whoever merges this PR: Please squash on merge, sufficient to have these changes in one commit.

@ownclouders
Copy link
Contributor

ownclouders commented Apr 28, 2022 •
edited
Loading

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/25033/68/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkEdit.feature:59

@lookacat lookacat changed the title Design polishing v3 [full-ci] Design polishing v3 Apr 28, 2022
@lookacat lookacat force-pushed the design-polishing-v4 branch from 13b5368 to 04267f5 Compare April 28, 2022 09:58
@lookacat lookacat force-pushed the design-polishing-v4 branch from 04267f5 to 9e193b4 Compare April 29, 2022 08:36
@pascalwengerter
Copy link
Contributor

Restarted CI and created a ticket for the problematic test in #6838

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit f07653e into master Apr 29, 2022
@delete-merged-branch delete-merged-branch bot deleted the design-polishing-v4 branch April 29, 2022 12:17
@micbar micbar mentioned this pull request May 5, 2022
Closed
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lookacat @kulmann @ownclouders @pascalwengerter