Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] mock v-translate directive in views tests #6733

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

individual-it
Copy link
Member

Description

mock v-translate here also, simmilar to https://github.com/owncloud/web/pull/6404/files#diff-0dd79c75d790d047f8dde209581a57ea4dc2708fcda916ad00f5aee313d7e02dR38

Related Issue

Motivation and Context

get rid of warnings like

    console.warn
      No translations found for en_US

      at Object.getTranslation (node_modules/vue-gettext/dist/vue-gettext.js:357:19)
      at updateTranslation (node_modules/vue-gettext/dist/vue-gettext.js:700:33)
      at bind (node_modules/vue-gettext/dist/vue-gettext.js:756:7)
      at callHook$1 (node_modules/vue/dist/vue.runtime.common.dev.js:6702:7)
      at _update (node_modules/vue/dist/vue.runtime.common.dev.js:6623:7)
      at Array.updateDirectives (node_modules/vue/dist/vue.runtime.common.dev.js:6604:5)
      at invokeCreateHooks (node_modules/vue/dist/vue.runtime.common.dev.js:6093:22)
      at createElm (node_modules/vue/dist/vue.runtime.common.dev.js:5980:11)

How Has This Been Tested?

running unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kulmann kulmann merged commit 3953462 into master Apr 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixTranslationPublicFilesTests branch April 5, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants