Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/group details and edit panel #6724

Merged
merged 26 commits into from
Apr 12, 2022
Merged

User/group details and edit panel #6724

merged 26 commits into from
Apr 12, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 4, 2022

Description

Implementation of the right sidebar for users and groups

Note: editing group name is currently not supported by backend

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Details

image

image

Edit

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear changed the title User details User/group details Apr 4, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Apr 4, 2022

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/24637/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear marked this pull request as ready for review April 4, 2022 14:45
@AlexAndBear AlexAndBear force-pushed the user-details branch 2 times, most recently from 522a20e to eb099ec Compare April 5, 2022 08:31
@AlexAndBear AlexAndBear force-pushed the user-details branch 3 times, most recently from 4c3349f to 649032e Compare April 5, 2022 12:34
@AlexAndBear AlexAndBear force-pushed the user-details branch 4 times, most recently from ec7d9a2 to 1c09995 Compare April 7, 2022 07:31
@AlexAndBear AlexAndBear changed the title User/group details User/group details and edit panel Apr 7, 2022
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, i have some code questions // requests.
Beside those i will ad a few ui comments with screenshots in a moment

Comment on lines +73 to +74
validateDisplayName() {
this.formData.displayName.valid = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be simplified

const valid = this.editGroup.displayName.trim() === ''
const messsage = valid ? this.$gettext('Display name cannot be empty') : ''

this.formData.displayName.errorMessage = message
this.formData.displayName.valid = valid

return valid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let me do the validation adjustments in a separate pr

packages/web-app-user-management/src/views/Users.vue Outdated Show resolved Hide resolved
packages/web-app-user-management/src/views/Users.vue Outdated Show resolved Hide resolved
packages/web-app-user-management/src/views/Users.vue Outdated Show resolved Hide resolved
packages/web-app-user-management/src/views/Users.vue Outdated Show resolved Hide resolved
@fschade
Copy link
Contributor

fschade commented Apr 11, 2022

The transparence in the sidebar CTA's look kinda strange.
Bildschirmfoto 2022-04-11 um 15 18 48

@fschade
Copy link
Contributor

fschade commented Apr 11, 2022

When the revert button is above an input, clicking the button triggers the input behind instead the button.
Bildschirmfoto 2022-04-11 um 15 20 09

@fschade
Copy link
Contributor

fschade commented Apr 11, 2022

The backend currently does not support renaming user groups, not sure if we should disable the save action or notify the user somehow. Memory for later

Bildschirmfoto 2022-04-11 um 15 22 54

@fschade
Copy link
Contributor

fschade commented Apr 11, 2022

Table Group and Role is empty, we need to rescope those.

Bildschirmfoto 2022-04-11 um 15 25 06

@fschade
Copy link
Contributor

fschade commented Apr 11, 2022

When creating a new group the modal groupname input isn't focused.
When closing the modal the focus does not jump back to the button.

Same applies to users.

Bildschirmfoto 2022-04-11 um 15 26 17

@fschade
Copy link
Contributor

fschade commented Apr 11, 2022

Users table status is empty.
Bildschirmfoto 2022-04-11 um 15 28 22

@AlexAndBear
Copy link
Contributor Author

Users table status is empty. Bildschirmfoto 2022-04-11 um 15 28 22

Fixed

@AlexAndBear
Copy link
Contributor Author

When creating a new group the modal groupname input isn't focused. When closing the modal the focus does not jump back to the button.

Same applies to users.

Bildschirmfoto 2022-04-11 um 15 26 17

Fixed

@AlexAndBear
Copy link
Contributor Author

Table Group and Role is empty, we need to rescope those.

Bildschirmfoto 2022-04-11 um 15 25 06

Fixed

@AlexAndBear
Copy link
Contributor Author

The backend currently does not support renaming user groups, not sure if we should disable the save action or notify the user somehow. Memory for later

Bildschirmfoto 2022-04-11 um 15 22 54

Removed (commented out) for now

@AlexAndBear
Copy link
Contributor Author

When the revert button is above an input, clicking the button triggers the input behind instead the button. Bildschirmfoto 2022-04-11 um 15 20 09

Fixed

@AlexAndBear
Copy link
Contributor Author

The transparence in the sidebar CTA's look kinda strange. Bildschirmfoto 2022-04-11 um 15 18 48

Fixed

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

70.5% 70.5% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear requested a review from fschade April 12, 2022 08:28
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care ❤️

@AlexAndBear AlexAndBear merged commit 186139d into master Apr 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the user-details branch April 12, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit profile data Show user details in right sidebar
4 participants