-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/group details and edit panel #6724
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/24637/17/1 |
522a20e
to
eb099ec
Compare
4c3349f
to
649032e
Compare
packages/web-app-user-management/src/components/Groups/GroupsList.vue
Outdated
Show resolved
Hide resolved
packages/web-app-user-management/src/components/Users/SideBar/DetailsPanel.vue
Outdated
Show resolved
Hide resolved
ec7d9a2
to
1c09995
Compare
bee9220
to
f2a06ad
Compare
c914b48
to
7e11602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, i have some code questions // requests.
Beside those i will ad a few ui comments with screenshots in a moment
packages/web-app-user-management/src/components/CompareSaveDialog.vue
Outdated
Show resolved
Hide resolved
packages/web-app-user-management/src/components/Groups/SideBar/DetailsPanel.vue
Outdated
Show resolved
Hide resolved
packages/web-app-user-management/src/components/Groups/SideBar/DetailsPanel.vue
Show resolved
Hide resolved
packages/web-app-user-management/src/components/Groups/SideBar/EditPanel.vue
Outdated
Show resolved
Hide resolved
validateDisplayName() { | ||
this.formData.displayName.valid = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be simplified
const valid = this.editGroup.displayName.trim() === ''
const messsage = valid ? this.$gettext('Display name cannot be empty') : ''
this.formData.displayName.errorMessage = message
this.formData.displayName.valid = valid
return valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, let me do the validation adjustments in a separate pr
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care ❤️
Description
Implementation of the right sidebar for users and groups
Note: editing group name is currently not supported by backend
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Details
Edit
Types of changes
Checklist:
Open tasks: