-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage id refactor #6602
Storage id refactor #6602
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
14ae477
to
ca314b5
Compare
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23712/60/1
|
Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23712/61/1
|
Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23712/71/1
|
SonarCloud Quality Gate failed. |
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23714/60/1
|
Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23714/71/1
|
Description
Rename
spaceId
tostorageId
. Also makes the helpers for creating a resource target location (in resource table and in search results) more generic by using the storage id if one exists.Motivation and Context
This is needed for upcoming adjustments where the
Shared with me
page will have link targets that are not identical for the whole page anymore but can be different per item / table row.How Has This Been Tested?
sufficient coverage in acceptance tests
spaces tested manually (spaces e2e tests will arrive later this week 🤞 )
Types of changes
Checklist: