Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage id refactor #6602

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Storage id refactor #6602

merged 2 commits into from
Mar 15, 2022

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Mar 15, 2022

Description

Rename spaceId to storageId. Also makes the helpers for creating a resource target location (in resource table and in search results) more generic by using the storage id if one exists.

Motivation and Context

This is needed for upcoming adjustments where the Shared with me page will have link targets that are not identical for the whole page anymore but can be different per item / table row.

How Has This Been Tested?

sufficient coverage in acceptance tests
spaces tested manually (spaces e2e tests will arrive later this week 🤞 )

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 15, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the storage-id-refactor branch from 14ae477 to ca314b5 Compare March 15, 2022 16:38
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23712/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23712/61/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:125

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23712/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

webUIPrivateLinks-accessingPrivateLinks_feature-L9.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

39.6% 39.6% Coverage
5.6% 5.6% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23714/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23714/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:9

@kulmann kulmann merged commit 38e3a15 into master Mar 15, 2022
@pascalwengerter pascalwengerter deleted the storage-id-refactor branch April 1, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants