Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark submit buttons as such explicitly #6548

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Mark submit buttons as such explicitly #6548

merged 2 commits into from
Mar 9, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Mar 7, 2022 •
edited
Loading

Description

We switched the default button type in ODS to "button", so we need to mark actual submit buttons as such.

Related Issue

Motivation and Context

see linked ODS issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Release ODS and bump version

@dschmidt dschmidt force-pushed the mark_submit_buttons branch from beb1710 to 09bed3a Compare March 7, 2022 21:51
@dschmidt dschmidt force-pushed the mark_submit_buttons branch from 6b52ae6 to d79cb70 Compare March 7, 2022 22:13
@dschmidt dschmidt changed the title [full-ci] Mark submit buttons as such explicitly WIP: Mark submit buttons as such explicitly Mar 7, 2022
@pascalwengerter
Copy link
Contributor

Needs a rebase once #6540 is merged since that includes an ODS pre-release with the complimentary changes :)

@pascalwengerter pascalwengerter changed the title WIP: Mark submit buttons as such explicitly Mark submit buttons as such explicitly Mar 9, 2022
@pascalwengerter pascalwengerter changed the base branch from master to nav-tags March 9, 2022 11:02
@pascalwengerter pascalwengerter merged commit f211004 into nav-tags Mar 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the mark_submit_buttons branch March 9, 2022 11:04
@pascalwengerter pascalwengerter mentioned this pull request Mar 9, 2022
Merged
10 tasks
pascalwengerter pushed a commit that referenced this pull request Mar 9, 2022
@dschmidt @pascalwengerter
Mark submit buttons as such explicitly as we changed the default butt…
bbf0e26 
…on type in ODS (#6548)

Co-authored-by: Pascal Wengerter <[email protected]>

Fix snapshot test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschmidt @pascalwengerter